Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Remove completed comment on parquet row group pruning #4167

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Nov 10, 2022

Remove an outdated comment noticed by @Ted-Jiang #4160 (comment)

@alamb alamb changed the title Minor; Remove completed comment on parquet row group pruing Minor; Remove completed comment on parquet row group pruning Nov 10, 2022
@alamb alamb marked this pull request as ready for review November 10, 2022 12:36
@github-actions github-actions bot added the core Core DataFusion crate label Nov 10, 2022
@alamb alamb changed the title Minor; Remove completed comment on parquet row group pruning Minor: Remove completed comment on parquet row group pruning Nov 10, 2022
@alamb alamb merged commit 456c254 into apache:master Nov 10, 2022
@ursabot
Copy link

ursabot commented Nov 10, 2022

Benchmark runs are scheduled for baseline = 4d621c5 and contender = 456c254. 456c254 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/cleanup_comments branch August 8, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants