Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: consolidate parquet custom_reader integration test into parquet_exec #4175

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Nov 11, 2022

Which issue does this PR close?

re #3463

Rationale for this change

The easier it is to find existing parquet tests the easier it is to evaluate our coverage

What changes are included in this PR?

I suggest reviewing this PR commit by commit. The

  1. The first commit moves the file
  2. the second cleans up the test code by removing a #clippy(allow) and an unnecessary level of indent

Are these changes tested?

They are all tests

They are run like:

cargo test  --test parquet_exec

And you can see the output like:

...
test parquet::custom_reader::route_data_access_ops_to_parquet_file_reader_factory ... ok

Are there any user-facing changes?

No tests only

@alamb alamb changed the title Minor: consolidate another parquet integration test into parquet_exec Minor: consolidate parquet custom_reader integration test into parquet_exec Nov 11, 2022
@github-actions github-actions bot added the core Core DataFusion crate label Nov 11, 2022
@alamb
Copy link
Contributor Author

alamb commented Nov 11, 2022

cc @crepererum

@alamb alamb force-pushed the alamb/consolidate_more_parquet_tests branch from 6831e0c to fcad29d Compare November 15, 2022 19:06
@alamb alamb requested a review from Ted-Jiang November 15, 2022 19:06
@alamb
Copy link
Contributor Author

alamb commented Nov 15, 2022

@Ted-Jiang or @crepererum I wonder if you would have time to review this PR?

Copy link
Member

@Ted-Jiang Ted-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice rearrangement.❤️

Copy link
Contributor

@crepererum crepererum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@alamb alamb merged commit f7201cf into apache:master Nov 16, 2022
@ursabot
Copy link

ursabot commented Nov 16, 2022

Benchmark runs are scheduled for baseline = 406c108 and contender = f7201cf. f7201cf is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/consolidate_more_parquet_tests branch August 8, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants