-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor: consolidate parquet custom_reader
integration test into parquet_exec
#4175
Minor: consolidate parquet custom_reader
integration test into parquet_exec
#4175
Conversation
custom_reader
integration test into parquet_exec
cc @crepererum |
6831e0c
to
fcad29d
Compare
@Ted-Jiang or @crepererum I wonder if you would have time to review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice rearrangement.❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
Benchmark runs are scheduled for baseline = 406c108 and contender = f7201cf. f7201cf is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
re #3463
Rationale for this change
The easier it is to find existing parquet tests the easier it is to evaluate our coverage
What changes are included in this PR?
I suggest reviewing this PR commit by commit. The
#clippy(allow)
and an unnecessary level of indentAre these changes tested?
They are all tests
They are run like:
cargo test --test parquet_exec
And you can see the output like:
Are there any user-facing changes?
No tests only