Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include test data and add aggregation tests in integration test #425

Merged
merged 2 commits into from
May 31, 2021

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented May 25, 2021

Which issue does this PR close?

Closes #428

Rationale for this change

we'd like to include the test data into psql so that we can test more realistically

What changes are included in this PR?

  • add create table and load csv statement in integration run

Are there any user-facing changes?

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2021

Codecov Report

Merging #425 (6028904) into master (321fda4) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
- Coverage   75.16%   75.16%   -0.01%     
==========================================
  Files         150      150              
  Lines       25144    25145       +1     
==========================================
  Hits        18899    18899              
- Misses       6245     6246       +1     
Impacted Files Coverage Δ
datafusion-cli/src/main.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 321fda4...6028904. Read the comment docs.

@jimexist jimexist force-pushed the load-more-data-integration-test branch 2 times, most recently from 6857908 to f89b706 Compare May 26, 2021 03:03
@jimexist jimexist marked this pull request as ready for review May 26, 2021 06:41
@jimexist jimexist changed the title include test data in integration test include test data and add aggregation tests in integration test May 26, 2021
@jimexist jimexist force-pushed the load-more-data-integration-test branch from ca782d8 to 35c5898 Compare May 26, 2021 07:36
@alamb
Copy link
Contributor

alamb commented May 26, 2021

The windows failure is unrelated


error: could not copy file from 'C:\Users\runneradmin\.cargo\bin\rustup-init.exe' to 'C:\Users\runneradmin\.cargo\bin\rustup.exe': The process cannot access the file because it is being used by another process. (os error 32)
ResourceUnavailable: D:\a\_temp\25f719e4-aedd-4bf5-b3e9-d027995ab838.ps1:3
Line |
   3 |  rustup default stable
     |  ~~~~~~~~~~~~~~~~~~~~~
     | Program 'rustup.exe' failed to run: The specified executable is not a valid application for this OS
     | platform.At D:\a\_temp\25f719e4-aedd-4bf5-b3e9-d027995ab838.ps1:3 char:1 + rustup default stable +

@alamb
Copy link
Contributor

alamb commented May 26, 2021

Thanks @jimexist -- this looks nice

@jimexist jimexist force-pushed the load-more-data-integration-test branch from 35c5898 to 844e9fd Compare May 30, 2021 17:05
@alamb alamb merged commit 80abb09 into apache:master May 31, 2021
@jimexist jimexist deleted the load-more-data-integration-test branch May 31, 2021 14:29
@houqp houqp added the datafusion Changes in the datafusion crate label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enrich integration test to include aggregate csv data
4 participants