minor: avoid a clone into string when checking ambiguous #4292
Conversation
|
CI failure due to #4294 (not this PR) |
| let result = logical_plan(sql); | ||
| assert!(result.is_err()); | ||
| let err = result.err().unwrap(); | ||
| assert_eq!(format!("{}", err), expected); |
There was a problem hiding this comment.
👍
You can also do the same thing like
| assert_eq!(format!("{}", err), expected); | |
| assert_eq!(err.to_string(), expected); |
|
Benchmark runs are scheduled for baseline = 712b9fd and contender = 71e345f. 71e345f is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?