-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to use Schedular in tpch benchmark #4361
Support to use Schedular in tpch benchmark #4361
Conversation
@@ -337,7 +344,13 @@ async fn execute_query( | |||
); | |||
} | |||
let task_ctx = ctx.task_ctx(); | |||
let result = collect(physical_plan.clone(), task_ctx).await?; | |||
let result = if enable_scheduler { | |||
let scheduler = Scheduler::new(num_cpus::get()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use num_cpus
to initial the size of thread pool.
274eb55
to
a3c010d
Compare
a3c010d
to
52bd409
Compare
This is a cool option! Just out of my own curiosity I've compared
|
@isidentical It's expected. There is a tracking issue: #2504 I add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool to see this, I really hope to eventually get back to working on this scheduler - currently it can't really do all that much better than tokio as we first need to add proper push-based execution - see here.
One thought might be to test the scheduler based benchmark in CI, but don't feel very strongly
Perhaps when I finish up integrating the row format everywhere I'll have some more time to work on this 😄
I'll start to do it after work and look forward to seeing you back! |
Benchmark runs are scheduled for baseline = 58b43f5 and contender = 010aded. 010aded is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
No
Rationale for this change
Support to test
Schedular
(the newest executor designed by @tustvold ) performance in tpch benchmarkWhat changes are included in this PR?
Support to use
Schedular
in tpch benchmarkAre these changes tested?
No need, I have checked in my local.
Are there any user-facing changes?
No