Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Add note about sqllogictest to contributor guide #4469

Merged
merged 2 commits into from
Dec 2, 2022
Merged

MINOR: Add note about sqllogictest to contributor guide #4469

merged 2 commits into from
Dec 2, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 1, 2022

Which issue does this PR close?

re #4460

Rationale for this change

make the harness added in #4395 by @mvanschellebeeck easier to find

What changes are included in this PR?

Add a pointer to these tests in the contributor guide

Are these changes tested?

N/A

Are there any user-facing changes?

@alamb alamb added the documentation Improvements or additions to documentation label Dec 1, 2022
@alamb
Copy link
Contributor Author

alamb commented Dec 1, 2022

cc @xudong963

@alamb alamb marked this pull request as ready for review December 1, 2022 21:27
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Dec 1, 2022
xudong963
xudong963 reviewed Dec 2, 2022
View reviewed changes
docs/source/contributor-guide/index.md
@@ -134,6 +134,10 @@ cargo test -p datafusion --tests sql_integration

One very important test is the [sql_integration](../../../datafusion/core/tests/sql_integration.rs) test which validates DataFusion's ability to run a large assortment of SQL queries against an assortment of data setups.

### sqllogictests Tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding some comparison with Rust Integration Tests and encouraging adding logictestes as far as possible?

@xudong963 xudong963 merged commit 5d69fa3 into apache:master Dec 2, 2022
@ursabot
Copy link

ursabot commented Dec 2, 2022

Benchmark runs are scheduled for baseline = b229e0f and contender = 5d69fa3. 5d69fa3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/sqllogic_docs branch August 8, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xudong963 xudong963 xudong963 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alamb @ursabot @xudong963