fix: remove wrong comment about having
#4555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandandan
approved these changes
Dec 8, 2022
liukun4515
reviewed
Dec 9, 2022
| @@ -1151,12 +1151,10 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { | |||
| // | |||
| // For example: | |||
| // | |||
| // SELECT c1 AS m FROM t HAVING m > 10; | |||
There was a problem hiding this comment.
is there any bug for the implementation?
There was a problem hiding this comment.
currently this sql can't work.
is there any bug for the implementation?
Discussion about this, you can see #4556
There was a problem hiding this comment.
Postgres agrees:
postgres=# create table t (c1 int);
CREATE TABLE
postgres=# insert into t values (1), (2);
INSERT 0 2
postgres=# SELECT c1 AS m FROM t HAVING m > 10;
ERROR: column "m" does not exist
LINE 1: SELECT c1 AS m FROM t HAVING m > 10;
^
postgres=# 
alamb
approved these changes
Dec 9, 2022
| @@ -1151,12 +1151,10 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { | |||
| // | |||
| // For example: | |||
| // | |||
| // SELECT c1 AS m FROM t HAVING m > 10; | |||
There was a problem hiding this comment.
Postgres agrees:
postgres=# create table t (c1 int);
CREATE TABLE
postgres=# insert into t values (1), (2);
INSERT 0 2
postgres=# SELECT c1 AS m FROM t HAVING m > 10;
ERROR: column "m" does not exist
LINE 1: SELECT c1 AS m FROM t HAVING m > 10;
^
postgres=# 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4554 .
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?