Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimize stack space required to plan deeply nested binary expressions #4787

Merged
merged 5 commits into from
Jan 2, 2023
Merged

Minimize stack space required to plan deeply nested binary expressions #4787

merged 5 commits into from
Jan 2, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 1, 2023

Which issue does this PR close?

Re #4065 from @andygrove

Rationale for this change

This is a follow on to #4779 which reduced the stack space needed to plan in debug builds. This PR minimizes the stack required as much as I know how.

What changes are included in this PR?

Special case BinaryOp (see comments for explination)

Are these changes tested?

Yes (existing + new tests)

Are there any user-facing changes?

No

@github-actions github-actions bot added core Core DataFusion crate sql SQL Planner labels Jan 1, 2023
alamb
alamb commented Jan 1, 2023
View reviewed changes
datafusion/core/tests/tpcds_planning.rs Outdated
@@ -343,7 +343,6 @@ async fn tpcds_logical_q63() -> Result<()> {
create_logical_plan(63).await
}

#[ignore] // thread 'q64' has overflowed its stack]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these tests will likely still fail due to #4786 but I figured I would let the CI run and see if we can squeek by

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They still fail: https://github.com/apache/arrow-datafusion/actions/runs/3817136119/jobs/6493197591

@jackwener jackwener mentioned this pull request Jan 1, 2023
Merged
@alamb alamb marked this pull request as ready for review January 1, 2023 14:23
@github-actions github-actions bot removed the core Core DataFusion crate label Jan 1, 2023
@alamb alamb merged commit bf48122 into apache:master Jan 2, 2023
@ursabot
Copy link

ursabot commented Jan 2, 2023

Benchmark runs are scheduled for baseline = f91f623 and contender = bf48122. bf48122 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/fix_more_overflow branch August 8, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dandandan Dandandan Dandandan approved these changes

Assignees
No one assigned
Labels
sql SQL Planner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alamb @ursabot @Dandandan