Handle trailing tbl column in TPCH benchmarks #4821
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
The tbl format is of the form
Note the trailing
|
. Interpreting this as CSV therefore adds an additional trailing column, currently the CSV reader just ignores this. However, with arrow 30 the reader now complains if you give it a schema that doesn't match the file. The changes in this PR work around thisWhat changes are included in this PR?
Adds an additional
__placeholder
column to the schema when reading from a tbl file, this can then be projected out. This was a quick way to workaround this issue without polluting the general codebase with support for what appears to be a TPCH specific data format?Are these changes tested?
Are there any user-facing changes?