Cleanup CI (#5040) #5047
Cleanup CI (#5040) #5047
Conversation
| @@ -32,10 +36,6 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| container: | |||
| image: amd64/rust | |||
| env: | |||
There was a problem hiding this comment.
This has been moved into setup-builder
| @@ -92,17 +87,10 @@ jobs: | |||
| uses: ./.github/actions/setup-builder | |||
| with: | |||
| rust-version: stable | |||
| - name: Build tests | |||
| run: | | |||
| export PATH=$PATH:$HOME/d/protoc/bin | |||
There was a problem hiding this comment.
This shouldn't be necessary
tustvold
force-pushed
the
ci-cleanup
branch
2 times, most recently
from
bc8bffc
to
dc0b00a
Compare
| @@ -478,19 +485,14 @@ jobs: | |||
| - name: Run tests | |||
| run: | | |||
| cd datafusion | |||
| # Force all hash values to collide | |||
| cargo test --all --features=force_hash_collisions | |||
| cargo test --lib --tests --features=force_hash_collisions | |||
There was a problem hiding this comment.
I couldn't see a compelling reason to also run the doctests here
There was a problem hiding this comment.
agreed -- no need to run doc tests
| cd datafusion | ||
| cargo test --features=pyarrow | ||
| - name: Run datafusion-common tests | ||
| run: cargo test -p datafusion-common --features=pyarrow |
There was a problem hiding this comment.
The only pyarrow code is in datafusion-common AFAICT
See #5048
There was a problem hiding this comment.
| run: | | ||
| echo "Installing ${{ inputs.rust-version }}" | ||
| rustup toolchain install ${{ inputs.rust-version }} | ||
| rustup default ${{ inputs.rust-version }} | ||
| rustup component add rustfmt | ||
| - name: Disable debuginfo generation | ||
| # Disable full debug symbol generation to speed up CI build and keep memory down |
| @@ -18,6 +18,10 @@ | |||
| name: Dev | |||
| on: [push, pull_request] | |||
|
|
|||
| concurrency: | |||
There was a problem hiding this comment.
I think adding rationale as comments will help avoid someone deleting this by mistake as part of some future "cleanup"
| concurrency: | |
| # Ensure when changes are pushed to a PR previously running jobs are canceled | |
| concurrency: |
| @@ -17,6 +17,10 @@ | |||
|
|
|||
| name: Labeler | |||
|
|
|||
| concurrency: | |||
There was a problem hiding this comment.
| concurrency: | |
| # Ensure when changes are pushed to a PR previously running jobs are canceled | |
| concurrency: |
| @@ -17,6 +17,10 @@ | |||
|
|
|||
| name: Rust | |||
|
|
|||
| concurrency: | |||
There was a problem hiding this comment.
| concurrency: | |
| # Ensure when changes are pushed to a PR previously running jobs are canceled | |
| concurrency: |
| cd datafusion | ||
| cargo test --features=pyarrow | ||
| - name: Run datafusion-common tests | ||
| run: cargo test -p datafusion-common --features=pyarrow |
There was a problem hiding this comment.
| @@ -478,19 +485,14 @@ jobs: | |||
| - name: Run tests | |||
| run: | | |||
| cd datafusion | |||
| # Force all hash values to collide | |||
| cargo test --all --features=force_hash_collisions | |||
| cargo test --lib --tests --features=force_hash_collisions | |||
There was a problem hiding this comment.
agreed -- no need to run doc tests
|
I am going to merge this in so we can unblock other PRs -- we can handle comments / issues as follow on. Thanks again @tustvold |
|
Benchmark runs are scheduled for baseline = ab00bc1 and contender = 0820eb9. 0820eb9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #5040
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?