-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sqllogicaltest: move union.rs #5075
Conversation
@melgenek thanks your review❤️. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jackwener and @melgenek for the review!
Benchmark runs are scheduled for baseline = fbff8e2 and contender = dd09212. dd09212 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
We seem to be getting CI errors on master, a superficial look suggest it may be related to this. |
Is there a related PR? |
I have reproduced this Problem, I will fix it. Thank you @ozankabak |
Which issue does this PR close?
move union.rs into sqllogicaltest.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?