Add NULL literal support for decimal and integers #5077
Conversation
| @@ -306,7 +322,7 @@ mod tests { | |||
| explicit_options.schema = Some(&schema); | |||
| ctx.register_csv("data", "tests/testdata/data.csv", explicit_options.clone()) | |||
| .await?; | |||
| ctx.register_csv("data2", "tests/testdata/data.csv", explicit_options) | |||
| ctx.register_csv("data2", "tests/testdata/data.csv", explicit_options.clone()) | |||
There was a problem hiding this comment.
You're right. The second one is not needed, since we cloned the first one. I also think the second call to register_csv() can just use the default option since we're not using the second table to test Decimals so I'll fix that as well.
Modified test
Cargo clippy fix Resolved merge conflict
nseekhao
force-pushed
the
substrait-partial-null-literal-support
branch
from
b7dc7e8
to
7e04fdb
Compare
|
Benchmark runs are scheduled for baseline = 3a1f033 and contender = 7d2318b. 7d2318b is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Modified test
Which issue does this PR close?
Part of #4897
Original PR: datafusion-contrib/datafusion-substrait#40
Rationale for this change
Applying PRs that were already merged in the original repo
What changes are included in this PR?
INT8,INT16,INT32DECIMAL128Are these changes tested?
Yes
Are there any user-facing changes?
No