Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decimal scalar dyn kernels #5179

Merged
merged 4 commits into from
Feb 6, 2023
Merged

Fix decimal scalar dyn kernels #5179

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c6cfaf
Fix decimal scalar dyn kernels
viirya Feb 4, 2023
72367ed
Try fix CI
viirya Feb 4, 2023
365ab59
Add test
viirya Feb 5, 2023
832e273
Revert "Try fix CI"
viirya Feb 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions datafusion/physical-expr/src/expressions/binary/kernels_arrow.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,28 +189,20 @@ pub(crate) fn add_decimal(
}

pub(crate) fn add_decimal_dyn_scalar(left: &dyn Array, right: i128) -> Result<ArrayRef> {
let left_decimal = left.as_any().downcast_ref::<Decimal128Array>().unwrap();
let (precision, scale) = get_precision_scale(left)?;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In last PR, forgot to update this and there.


let array = add_scalar_dyn::<Decimal128Type>(left, right)?;
let decimal_array = as_decimal128_array(&array)?;
let decimal_array = decimal_array
.clone()
.with_precision_and_scale(left_decimal.precision(), left_decimal.scale())?;
Ok(Arc::new(decimal_array))
decimal_array_with_precision_scale(array, precision, scale)
}

pub(crate) fn subtract_decimal_dyn_scalar(
left: &dyn Array,
right: i128,
) -> Result<ArrayRef> {
let left_decimal = left.as_any().downcast_ref::<Decimal128Array>().unwrap();
let (precision, scale) = get_precision_scale(left)?;

let array = subtract_scalar_dyn::<Decimal128Type>(left, right)?;
let decimal_array = as_decimal128_array(&array)?;
let decimal_array = decimal_array
.clone()
.with_precision_and_scale(left_decimal.precision(), left_decimal.scale())?;
Ok(Arc::new(decimal_array))
decimal_array_with_precision_scale(array, precision, scale)
}

fn get_precision_scale(left: &dyn Array) -> Result<(u8, i8)> {
Expand Down