Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix propagating empty_relation generates an illegal plan #5219

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

yukkit
Copy link
Contributor

@yukkit yukkit commented Feb 8, 2023

Which issue does this PR close?

Closes #5218 .

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the optimizer Optimizer rules label Feb 8, 2023
Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks you @yukkit.

@yukkit
Copy link
Contributor Author

yukkit commented Feb 8, 2023

Can you help merge the pr, I'm going to use this commit @jackwener

@jackwener
Copy link
Member

jackwener commented Feb 8, 2023

Can you help merge the pr, I'm going to use this commit @jackwener

I can understand what you want.

BUT, even if I merge this PR, you also can't use it right away because it doesn't be included in release version.

If you want to use master branch to get this PR (after this PR was merged), I don't recommend you this method, because master branch isn't stable branch, which may cause other problem.

@alamb
Copy link
Contributor

alamb commented Feb 8, 2023

Thank you @yukkit and @jackwener

@alamb alamb merged commit e166500 into apache:master Feb 8, 2023
@alamb
Copy link
Contributor

alamb commented Feb 8, 2023

BTW if you do want to try out DataFusion directly from master you can use something like this in your Cargo.toml

[patch.crates-io]
datafusion = { git = "https://github.com/apache/arrow-datafusion.git", branch="master" }

@ursabot
Copy link

ursabot commented Feb 8, 2023

Benchmark runs are scheduled for baseline = b4cf60a and contender = e166500. e166500 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimizer Optimizer rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Propagating empty_relation generate an illegal plan
4 participants