[fix][plan] relax the check for distinct, order by for dataframe #5258
Conversation
github-actions
bot
added
core
In pr apache#5132, we added a check that order by expr list must exist in distinct expr list, this restriction may be over eager for dataframe user, sometimes they may want to do this for some particular reasons. In this pr, we relax the check for distinct, order by for dataframe, this check will only be triggered for sql planner. Signed-off-by: xyz <a997647204@gmail.com>
xiaoyong-z
force-pushed
the
order-by-bugfix2
branch
from
98bb9b8
to
83d9864
Compare
|
Thanks again @xiaoyong-z |
|
Benchmark runs are scheduled for baseline = ec24724 and contender = 90e03e4. 90e03e4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
I have another follow on #5307 -- sorry for all the churn here. |
…che#5258) In pr apache#5132, we added a check that order by expr list must exist in distinct expr list, this restriction may be over eager for dataframe user, sometimes they may want to do this for some particular reasons. In this pr, we relax the check for distinct, order by for dataframe, this check will only be triggered for sql planner. Signed-off-by: xyz <a997647204@gmail.com>
Which issue does this PR close?
Closes #5255
Rationale for this change
In pr #5132, we added a check that order by expr list must exist in distinct expr list, this restriction may be over eager for dataframe user, sometimes they may want to do this for some particular reasons.
What changes are included in this PR?
In this pr, we relax the check for distinct, order by for dataframe, this check will only be triggered for sql planner.
Are these changes tested?
yes
Are there any user-facing changes?
no