Skip to content

fix: build union schema with child has same column name but qualifier… #5452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2023
Merged

fix: build union schema with child has same column name but qualifier… #5452

merged 1 commit into from
Mar 4, 2023

Conversation

@yukkit
Copy link
Contributor

@yukkit yukkit commented Mar 2, 2023

… is different

Which issue does this PR close?

Closes #5410 .

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the logical-expr Logical plan and expressions label Mar 2, 2023
@github-actions github-actions bot added core Core DataFusion crate optimizer Optimizer rules sql SQL Planner labels Mar 2, 2023
jackwener
jackwener reviewed Mar 2, 2023
View reviewed changes
datafusion/expr/src/logical_plan/builder.rs Outdated

Ok(DFField::new(
None,
left_field.qualifier().map(|x| &**x),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
left_field.qualifier().map(|x| &**x),
left_field.qualifier().map(|x| x.as_ref()),

jackwener
jackwener approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR use left-side qualifier instead of discard qualifier when build union.
Make sense to me

datafusion/expr/src/logical_plan/builder.rs
fn test_union_after_join() -> Result<()> {
let values = vec![vec![lit(1)]];

let left = LogicalPlanBuilder::values(values.clone())?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb alamb merged commit 53a638e into apache:main Mar 4, 2023
@ursabot
Copy link

ursabot commented Mar 4, 2023

Benchmark runs are scheduled for baseline = 8d195a8 and contender = 53a638e. 53a638e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@andygrove andygrove added the bug Something isn't working label Mar 12, 2023
@yukkit yukkit mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackwener jackwener jackwener approved these changes

Assignees

No one assigned

Labels

bug Something isn't working core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules sql SQL Planner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Join two tables with the same schema, then union throws SchemaError(DuplicateUnqualifiedField )

5 participants

@yukkit @ursabot @jackwener @alamb @andygrove