Move TaskContext
to DataFusion execution without SessionConfig
#5582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft as builds on #5580
Which issue does this PR close?
Part of #1754
Rationale for this change
I am trying to extract the physical_plan code into its own crate; and to do so I need to remove the circular dependencies between core --> datasource --> execution --> datasource
The
TaskContext
is the part of theSessionState
that is used at runtime, so I want it it into thedatafusion_execution
crate.See more details in #1754 (comment)
What changes are included in this PR?
TaskContext
todatafusion_execution
session_config: SessionConfig,
field to its two fieldsextensions
andconfig_options
Are these changes tested?
Covered by existing tests
Are there any user-facing changes?
Yes, anyone who uses SessionConfig in their execution plans will have to update their code to use
config_options
orextensions
directly.I am worried that this is too much API churn (though I think the resulting API is cleaner). I also have a PR to move
SessionConfig
intodatafusion_execution
.#5581