Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TaskContext to DataFusion execution without SessionConfig #5582

Closed
wants to merge 3 commits into from

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Mar 13, 2023

Draft as builds on #5580

Which issue does this PR close?

Part of #1754

Rationale for this change

I am trying to extract the physical_plan code into its own crate; and to do so I need to remove the circular dependencies between core --> datasource --> execution --> datasource

The TaskContext is the part of the SessionState that is used at runtime, so I want it it into the datafusion_execution crate.

See more details in #1754 (comment)

What changes are included in this PR?

  1. Move TaskContext to datafusion_execution
  2. Change session_config: SessionConfig, field to its two fields extensions and config_options

Are these changes tested?

Covered by existing tests

Are there any user-facing changes?

Yes, anyone who uses SessionConfig in their execution plans will have to update their code to use config_options or extensions directly.

I am worried that this is too much API churn (though I think the resulting API is cleaner). I also have a PR to move SessionConfig into datafusion_execution.
#5581

@github-actions github-actions bot added the core Core DataFusion crate label Mar 13, 2023
@alamb alamb changed the title Move TaskContext to DataFusion execution Move TaskContext to DataFusion execution without SessionConfig Mar 13, 2023
@alamb alamb closed this Mar 13, 2023
@alamb alamb deleted the alamb/extract_task_ctx_try_2 branch October 18, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant