add CountWildcardRule to fix error on Count(Expr:Wildcard) with DataFrame API #5627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
Contributor
Author
|
cc @mingmwang am I doing this right? |
jiangzhx
force-pushed
the
add_count_wildcard_rule
branch
from
561b03b to
9dd162f
Compare
jiangzhx
force-pushed
the
add_count_wildcard_rule
branch
3 times, most recently
from
c9cc6ea to
00cccce
Compare
jiangzhx
force-pushed
the
add_count_wildcard_rule
branch
from
00cccce to
5334a6f
Compare
alamb
approved these changes
Mar 18, 2023
Contributor
|
I think it looks good -- we can address any comments as a follow on PR. Thanks again @jiangzhx |
Contributor
|
Follow on PR: #5671 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5473