-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmarks to window function queries #564
Conversation
Codecov Report
@@ Coverage Diff @@
## master #564 +/- ##
==========================================
- Coverage 76.12% 76.08% -0.04%
==========================================
Files 156 156
Lines 27074 27121 +47
==========================================
+ Hits 20609 20635 +26
- Misses 6465 6486 +21
Continue to review full report at Codecov.
|
1a8d5e7
to
7a9c359
Compare
085a6a6
to
07ece7d
Compare
updated benchmark:
|
@Dandandan @alamb this benchmark is now updated and rebased |
updated to 1million samples, 8k batch size:
|
07ece7d
to
db91c81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @jimexist
Which issue does this PR close?
Based on #558 so review that first.
Closes #565
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?