Remove SortKeyCursor (~5-10% faster merge) #5895
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #5882
Relates to #5879
Rationale for this change
Replaces SortKeyCursor with a simplified, crate-private version. I couldn't see an obvious reason why SortKeyCursor was public other than to enable integration tests. Especially now that arrow-row exists, I don't see a compelling reason to keep it around.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
Yes SortKeyCursor is removed, it is highly unlikely anyone was using this as it is very coupled with SortPreservingMerge