Update to arrow 38 #6115
Merged
Update to arrow 38 #6115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
tustvold
commented
Apr 25, 2023
| @@ -1089,7 +1089,7 @@ mod tests { | |||
| #[tokio::test] | |||
| async fn test_sort_fetch_memory_calculation() -> Result<()> { | |||
| // This test mirrors down the size from the example above. | |||
| let avg_batch_size = 6000; | |||
| let avg_batch_size = 5000; | |||
There was a problem hiding this comment.
Arrays are smaller because of apache/arrow-rs#4061
|
🤔 there appear to be more changes needed to tests in other modules |
tustvold
commented
Apr 25, 2023
| @@ -303,7 +303,7 @@ select arrow_cast('30 minutes', 'Interval(MonthDayNano)'); | |||
|
|
|||
| ## Duration | |||
|
|
|||
| query error DataFusion error: Error during planning: Cannot automatically convert Interval\(MonthDayNano\) to Duration\(Second\) | |||
| query error DataFusion error: This feature is not implemented: Can't create a scalar from array of type "Duration\(Second\)" | |||
There was a problem hiding this comment.
I think this is the result of apache/arrow-rs#4020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?