Fix build #627
Merged
Fix build #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
pushed a commit
to andygrove/datafusion
that referenced
this pull request
Jan 31, 2025
…pache#627) * dedup code * transforming the dict directly * code optimization for cast string to timestamp * minor optimizations * fmt fixes and casting to dict array without unpacking to array first * bug fixes * revert unrelated change * Added test case and code refactor * minor optimization * minor optimization again * convert the cast to array * Revert "convert the cast to array" This reverts commit 9270aedeafa12dacabc664ca9df7c85236e05d85. * bug fixes * rename the test to cast_dict_to_timestamp arr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Fix build.
What changes are included in this PR?
Update a test to use the new
Column::newsignature that takes an index.Are there any user-facing changes?
No