Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

honor table name for csv/parquet scan in ballista plan serde #629

Merged
merged 2 commits into from
Jun 27, 2021

Conversation

houqp
Copy link
Member

@houqp houqp commented Jun 26, 2021

Which issue does this PR close?

Closes #623.

Rationale for this change

Table names are discarded during parquet and csv table node deserialization.

What changes are included in this PR?

Add two new plan builder public methods to allow building csv and parquet table with name.

Are there any user-facing changes?

@github-actions github-actions bot added ballista datafusion Changes in the datafusion crate labels Jun 26, 2021
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @houqp!

@Dandandan Dandandan merged commit c21106e into apache:master Jun 27, 2021
@houqp houqp added the bug Something isn't working label Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working datafusion Changes in the datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ballista integration tests are failing
3 participants