[sqllogictest] port tests in avro.rs to sqllogictest

[e1ijah1]

Which issue does this PR close?

Closes #6299

Rationale for this change

#6195

What changes are included in this PR?

Port the Rust unit tests from avro.rs, excluding avro_query_multiple_files, to sqllogictest.

Are these changes tested?

yes.

Are there any user-facing changes?

[alamb]

Thank you for the contribution @e1ijah1 -- this is looking very close. I left some comments about how to port the last test. Thank you 🙏

[alamb]

I see that this test was not ported directly -- since the avro code uses the same codepath as all the other listing tables for handling multiple files it is probably ok.

However, I think it is important coverage to maintain as the end to end coverage makes sure everything is hooked up correctly.

I think the issue is there is no way to setup these files using sqllogictest. Perhaps you can add a special sqllogictest test setup (to make the directory with multiple files) following this model:

https://github.com/apache/arrow-datafusion/blob/b578c5819fc05801f2972dd427fbc13cf4773ea8/datafusion/core/tests/sqllogictests/src/main.rs#L171

[e1ijah1]

Considering that avro_query_multiple_files utilizes a temporary directory, could we maintain the temporary directory within SessionContext to facilitate the creation of necessary data during the setup phase?

[alamb]

🤔 I think adding something to SessionContext for testing only is likely not the best idea

Maybe we could return the TempDir alongside the SessionContext like:

struct TestContext {
  /// Context for running queries
  ctx: SessionContext,
  /// Temporary directory created and cleared at the end of the test
  tmpdir: TempDir
}

And then change

async fn context_for_test_file(relative_path: &Path) -> SessionContext {

to

async fn context_for_test_file(relative_path: &Path) -> TestContext {

[e1ijah1]

Thank you for taking the time to review my PR 🙏. I have updated the code. Please take another look.

[alamb]

Looks great -- thank you @e1ijah1

[alamb]

This PR was failing on CI: https://github.com/apache/arrow-datafusion/actions/runs/5010297388/jobs/8991828477 -- I pushed some fixes for cargo fmt and the hash collisions failures. Hopefully the tests pass this time

[alamb]

Thanks again @e1ijah1