Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nullability calculation for boolean expressions #6365

Merged
merged 1 commit into from
May 17, 2023
Merged

Fix nullability calculation for boolean expressions #6365

merged 1 commit into from
May 17, 2023

Conversation

jonahgao
Copy link
Member

Which issue does this PR close?

None

Rationale for this change

These boolean expressions should never be null.
This bug seems to have been accidentally introduced by #4490 : L201

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added the logical-expr Logical plan and expressions label May 16, 2023
alamb
alamb approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @byteink -- I agree that these boolean expressions will never be nullable

@alamb alamb merged commit 19b0324 into apache:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
logical-expr Logical plan and expressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonahgao @alamb