-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support type cast in SchemaAdapter #6404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice, thank you. Left some minor comments, but this is also good to go as is
Thank you for taking the time to review my PR 🙏. I have updated the code. Please take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Which issue does this PR close?
Closes #6381
Rationale for this change
What changes are included in this PR?
introduces a
map_schema
method that maps the file schema to the table schema, and aSchemaMapping
structure to hold the mapping and necessary type conversions.Are these changes tested?
Yes
Are there any user-facing changes?