Move physical_plan::file_format
to datasource::plan
#6516
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This is part of #1754
Rationale for this change
While trying to extract
physical_plan
out of the core datafusion crate, the implementation of the various formats need to instantiateExecutionPlan
s (e.g.ParquetExec
) -- so therefore I conclude I need to remove the dependency out of physical_planWhat changes are included in this PR?
physical_plan::file_format
todatasource::physical_plan
Are these changes tested?
Existing tests
Are there any user-facing changes?
Yes, this does change the import path for anyone who uses structures like
ParquetExec
, etcfrom
To
I would be open to other suggestions too.
Sorry in advance