Move JoinType and JoinCondition to datafusion_common
#6572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
force-pushed
the
alamb/move_join_type
branch
from
fc77450
to
5d244d8
Compare
alamb
commented
Jun 6, 2023
| @@ -57,7 +57,6 @@ use crate::arrow::array::BooleanBufferBuilder; | |||
| use crate::arrow::datatypes::TimeUnit; | |||
| use crate::error::{DataFusionError, Result}; | |||
| use crate::execution::{context::TaskContext, memory_pool::MemoryConsumer}; | |||
| use crate::logical_expr::JoinType; | |||
There was a problem hiding this comment.
The point of this PR is to remove the logical_expr uses from physical_plan
alamb
changed the title
JoinType and JoinCondition to datafusion_commonJoinType and JoinCondition to datafusion_common
|
Thank you for the review @Dandandan ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #1754 (see #1754 (comment))
Rationale for this change
I am trying to extract
physical_planinto its own crate to improve modularity and compile timesJoinTypeand related structures to are used in physical_plan and I would like to avoid physical_plan depending on the logical plansWhat changes are included in this PR?
JoinTypeandJoinConditiontodatafusion_commonAre these changes tested?
Existing tests
Are there any user-facing changes?
No, I left a backwards compatible
pub use