Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Remove some use crate:: uses in physical_plan #6573

Merged
merged 3 commits into from
Jun 8, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jun 6, 2023

Which issue does this PR close?

Part of #1754 (see #1754 (comment))

Rationale for this change

I am trying to extract physical_plan into its own crate to improve modularity and compile times

What changes are included in this PR?

  1. Update use crate::error to use datafusion_common in physical_plan to remove a dependency on a pub use in datafusion core
  2. Update various other use statements to avoid use crate when possible

Are these changes tested?

Existing tests

Are there any user-facing changes?

No API change

@github-actions github-actions bot added the core Core DataFusion crate label Jun 6, 2023
@alamb alamb changed the title Update use crate::error to use datafusion_common in physical_plan Remove some use crate:: uses in physical_plan Jun 6, 2023
};
use arrow::{array::StringBuilder, datatypes::SchemaRef, record_batch::RecordBatch};
use datafusion_common::{DataFusionError, Result};
Copy link
Contributor Author

@alamb alamb Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is pretty boring and it just updates a bunch of use statements

@alamb alamb marked this pull request as ready for review June 7, 2023 12:04
@alamb alamb changed the title Remove some use crate:: uses in physical_plan Minor: Remove some use crate:: uses in physical_plan Jun 7, 2023
Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alamb

@alamb alamb merged commit d689daf into apache:main Jun 8, 2023
jayzhan211 pushed a commit to jayzhan211/datafusion that referenced this pull request Jun 12, 2023
* Update `use crate::error` to `use datafusion_common` in physical_plan

* More updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants