Fix timestamp_add_interval_months to pass any date #6815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Dandandan
reviewed
Jul 1, 2023
| @@ -579,8 +579,8 @@ async fn timestamp_add_interval_months() -> Result<()> { | |||
| let t1_naive = chrono::NaiveDateTime::parse_from_str(res1, format).unwrap(); | |||
| let t2_naive = chrono::NaiveDateTime::parse_from_str(res2, format).unwrap(); | |||
|
|
|||
| let year = t1_naive.year() + (t1_naive.month() as i32 + 17) / 12; | |||
| let month = (t1_naive.month() + 17) % 12; | |||
| let year = t1_naive.year() + (t1_naive.month0() as i32 + 17) / 12; | |||
There was a problem hiding this comment.
Instead of using NOW() we could use some table of dates instead to test it?.
There was a problem hiding this comment.
This would avoid the test breaking suddenly on a certain date.
There was a problem hiding this comment.
@Dandandan It seems your suggestion is great, it failed today again :(
Dandandan
approved these changes
Jul 1, 2023
2010YOUY01
pushed a commit
to 2010YOUY01/arrow-datafusion
that referenced
this pull request
Jul 5, 2023
* fix Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * use month0 Signed-off-by: jayzhan211 <jayzhan211@gmail.com> --------- Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6814.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?