Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Outdated NY Taxi benchmark #7210

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Aug 5, 2023

Which issue does this PR close?

Part of #7052

Rationale for this change

  1. This is not a standard benchmark
  2. The benchmark code currently checked into the repo is a single low cardinality grouping query, a scenario that is already well covered by both tpch and clickbench
  3. I also think the benchmark has atrophied (because, for example, the https://www.nyc.gov/site/tlc/about/tlc-trip-record-data.page now only supplies parquet where the benchmark still has references to CSV data)

FWIW the query is:

SELECT passenger_count, MIN(fare_amount), MAX(fare_amount), SUM(fare_amount) FROM tripdata GROUP BY passenger_count");

What changes are included in this PR?

Remove the NY taxi benchmark code and entry in readme

Are these changes tested?

Are there any user-facing changes?

@alamb alamb requested a review from andygrove August 5, 2023 17:35
@alamb
Copy link
Contributor Author

alamb commented Aug 5, 2023

@andygrove / @Dandandan do you know of anyone using the nytaxi benchmark?

Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to remove by me

Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me

@jackwener jackwener merged commit eace3a7 into apache:main Aug 7, 2023
21 checks passed
@alamb alamb deleted the alamb/remove_nytaxi branch August 7, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants