Minor: Move project_schema to datafusion_common
#7237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Aug 8, 2023
| @@ -50,7 +50,7 @@ use crate::{ | |||
| error::{DataFusionError, Result}, | |||
| execution::context::SessionState, | |||
| logical_expr::Expr, | |||
| physical_plan::{empty::EmptyExec, project_schema, ExecutionPlan, Statistics}, | |||
There was a problem hiding this comment.
Long term I would like to cut the dependency between physical_plan and datasource -- but I need to get physical_plan extracted first
viirya
approved these changes
Aug 8, 2023
jackwener
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #1754
Rationale for this change
As part of preparing (finally) to move the physical_plan into its own crate so datafusion builds faster and is more modular, I am trying to clean up cross module dependencies where I find them
What changes are included in this PR?
project_schemainto datafusion_commonuseforproject_schemaindatasourceAre these changes tested?
tested by existing tests
Are there any user-facing changes?
No -- I left a
pub usefor backwards compatibility