Update physical_plan tests to not use SessionContext
#7243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
commented
Aug 9, 2023
| @@ -1449,8 +1447,7 @@ mod tests { | |||
| DataType::Int64, | |||
| ))]; | |||
|
|
|||
| let session_ctx = SessionContext::new(); | |||
| let task_ctx = session_ctx.task_ctx(); | |||
| let task_ctx = Arc::new(TaskContext::default()); | |||
There was a problem hiding this comment.
This pattern is 95% of this PR: create the TaskContext directly rather than via a SessionContext
| use crate::test::create_vec_batches; | ||
| use arrow::datatypes::{DataType, Field, Schema}; | ||
|
|
||
| #[tokio::test] |
There was a problem hiding this comment.
These are tests that a config option makes it through to planning SQL, so I moved them to options.slt
| @@ -1811,173 +1799,14 @@ mod tests { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| async fn join_change_in_planner() -> Result<()> { | |||
There was a problem hiding this comment.
these are SQL level tests that need to entire SessionContext so I moved it to the core_integration test
| @@ -1231,7 +1230,6 @@ mod tests { | |||
| DisplayAs, ExecutionPlan, Partitioning, RecordBatchStream, | |||
| SendableRecordBatchStream, Statistics, | |||
| }; | |||
| use crate::prelude::SessionContext; | |||
There was a problem hiding this comment.
The point of this PR is to remove these dependencies
crepererum
approved these changes
Aug 9, 2023
yjshen
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #1754
Rationale for this change
As part of preparing (finally) to move the physical_plan into its own crate so datafusion builds faster and is more modular, I need to cut all
physical_plan-->coredependencies. SessionContext is incoreWhat changes are included in this PR?
TaskContext(which is what they mostly need anyways)Are these changes tested?
Yes
Are there any user-facing changes?
No