Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Test in information_schema.slt fails #7286

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Conversation

sarutak
Copy link
Member

@sarutak sarutak commented Aug 15, 2023

Which issue does this PR close?

Closes #7285

Rationale for this change

This PR aims to fix an issue that test in information_schema.slt fails consistently after #7270.
https://github.com/apache/arrow-datafusion/actions/runs/5858702865/job/15883174290

Are these changes tested?

GitHub Actions.

Are there any user-facing changes?

No.

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Aug 15, 2023
@sarutak sarutak changed the title Hotfix Hotfix: Test in information_schema.slt fails after 29.0.0 released Aug 15, 2023
@sarutak sarutak changed the title Hotfix: Test in information_schema.slt fails after 29.0.0 released Hotfix: Test in information_schema.slt fails Aug 15, 2023
@sarutak sarutak mentioned this pull request Aug 15, 2023
Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another place:

--- a/docs/source/user-guide/configs.md
+++ b/docs/source/user-guide/configs.md
@@ -64,7 +64,7 @@ Environment variables are read during `SessionConfig` initialisation so they mus
 | datafusion.execution.parquet.statistics_enabled            | page                      | Sets if statistics are enabled for any column Valid values are: "none", "chunk", and "page" These values are not case sensitive.                                                                                                                                                                                                                                                                                                                                                                                                                                                                        |
 | datafusion.execution.parquet.max_statistics_size           | 4096                      | Sets max statistics size for any column                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                 |
 | datafusion.execution.parquet.max_row_group_size            | 1048576                   | Sets maximum number of rows in a row group                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                              |
-| datafusion.execution.parquet.created_by                    | datafusion version 28.0.0 | Sets "created by" property                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                              |
+| datafusion.execution.parquet.created_by                    | datafusion version 29.0.0 | Sets "created by" property                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                              

@sarutak
Copy link
Member Author

sarutak commented Aug 15, 2023

Yeah, I noticed too...

@viirya viirya merged commit 6ad7916 into apache:main Aug 15, 2023
@viirya
Copy link
Member

viirya commented Aug 15, 2023

Merged to restore CI. Thanks @sarutak

@alamb
Copy link
Contributor

alamb commented Aug 15, 2023

Thank you @sarutak and @viirya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test in information_schema.slt fails consistently
3 participants