Minor: Extract FileScanConfig into its own module
#7335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
changed the title
FileScanConfig into its own module
yjshen
approved these changes
Aug 18, 2023
alamb
commented
Aug 21, 2023
| gen_u64: ZeroBufferGenerator<u64>, | ||
| } | ||
|
|
||
| /// Generate a arrow [`Buffer`] that contains zero values. |
There was a problem hiding this comment.
There are probably nicer ways to do this now with the arrow-rs APIs (like Array::from(vec![0; size])) but I didn't make the change in this PR
cc @tustvold if you have any thoughts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #1754 as well as making it easier to work with datafusion code
Rationale for this change
core/src/datasource/physical_plan/mod.rswas large with several unrelated structures in it, making it hard to navigateWhat changes are included in this PR?
This PR just moves some of the code into
file_scan_config.rsAre these changes tested?
Covered by existing tests
Are there any user-facing changes?
No