Minor: Fix bug in AND interval analysis tests (not code), and add more coverage
#7886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
AND interval analysis, and add more coverageAND interval analysis tests (not code), and add more coverage
alamb
commented
Oct 20, 2023
| (false, true, true, true, false, true), | ||
| (false, false, false, false, false, false), | ||
| (true, true, true, true, true, true), | ||
| // Note there are only three valid boolean intervals: [false, false], [false, true] and [true, true], |
There was a problem hiding this comment.
I added the three missing cases and reordered the cases so it was easier to see what is covered and what was not.
3 tasks
|
Marking as a draft until @berkaysynnada 's refactor PR has landed |
|
Superseded by #8276 (the whole notion of open intervals has been removed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to https://github.com/apache/arrow-datafusion/pull/7884/files
Rationale for this change
When I was figuring out how to add
ORsupport for interval analysis, I noticed:open_open, which as shown on Minor: Clarify BooleanIntervalhandling and verify it with a test #7885 means all the cases actually were testing the sameWhat changes are included in this PR?
closed_closedAre these changes tested?
Are there any user-facing changes?