Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TreeNode recursions #7942

Closed
wants to merge 11 commits into from

Commits on Dec 19, 2023

  1. POC

    peter-toth committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    c0990de View commit details
    Browse the repository at this point in the history
  2. - refactor transform_down() and transform_up() to work on mutable…

    … `TreeNode`s and use them in a few examples
    
    - add `transform_down_with_payload()`, `transform_up_with_payload()`, `transform_with_payload()` and use it in `EnforceSorting` as an example
    peter-toth committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    5c61470 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8fa80e7 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. make TreeNode methods naming consitent, after this change we have `…

    …visit()`, `visit_down()`, `transform()`, `transform_down()`, `transform_up()`, `transform_with_payload()`, `transform_down_with_payload()` and `transform_up_with_payload()` functions on `TreeNode`, others can be deprecated and removed once no longer used
    peter-toth committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    f4d28e0 View commit details
    Browse the repository at this point in the history
  2. fix transform_with_payload() to behave like `transform_down_with_pa…

    …yload()` in its pre-order transform (`f_down`) function
    peter-toth committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    9279c6a View commit details
    Browse the repository at this point in the history
  3. add docs

    peter-toth committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    8882285 View commit details
    Browse the repository at this point in the history
  4. Merge remote-tracking branch 'origin/main' into refactor-treenode-apply

    # Conflicts:
    #	datafusion/expr/src/expr.rs
    #	datafusion/expr/src/utils.rs
    peter-toth committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    aa333d1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6cd5d39 View commit details
    Browse the repository at this point in the history
  6. fix docs

    peter-toth committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    25b75bb View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. revert transform_with_payload, transform_down_with_payload and `t…

    …ransform_up_with_payload` related changes
    peter-toth committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    9e13bea View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Merge remote-tracking branch 'origin/main' into refactor-treenode-apply

    # Conflicts:
    #	datafusion/common/src/tree_node.rs
    #	datafusion/core/src/datasource/physical_plan/parquet/row_groups.rs
    #	datafusion/core/src/physical_optimizer/enforce_distribution.rs
    #	datafusion/core/src/physical_optimizer/enforce_sorting.rs
    #	datafusion/core/src/physical_optimizer/pipeline_checker.rs
    #	datafusion/core/src/physical_optimizer/replace_with_order_preserving_variants.rs
    #	datafusion/core/src/physical_optimizer/sort_pushdown.rs
    #	datafusion/expr/src/tree_node/expr.rs
    #	datafusion/expr/src/tree_node/plan.rs
    #	datafusion/optimizer/src/analyzer/count_wildcard_rule.rs
    #	datafusion/optimizer/src/analyzer/type_coercion.rs
    #	datafusion/optimizer/src/push_down_filter.rs
    #	datafusion/physical-expr/src/equivalence.rs
    #	datafusion/physical-expr/src/sort_properties.rs
    #	datafusion/physical-expr/src/utils/mod.rs
    peter-toth committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    f0b15e5 View commit details
    Browse the repository at this point in the history