Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: clean up the code regarding clippy #8122

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Minor: clean up the code regarding clippy #8122

merged 1 commit into from
Nov 10, 2023

Conversation

Weijun-H
Copy link
Member

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added sql SQL Planner core Core DataFusion crate labels Nov 10, 2023
comphead
comphead approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @Weijun-H

@alamb alamb merged commit fdf3f6c into apache:main Nov 10, 2023
@alamb
Copy link
Contributor

alamb commented Nov 10, 2023

Thank you @comphead and @Weijun-H

@matthewgapp matthewgapp mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comphead comphead comphead approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate sql SQL Planner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Weijun-H @alamb @comphead