ArraySum #8325
Closed
ArraySum #8325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
Weijun-H
reviewed
Dec 13, 2023
| array_sum([1, 3, 5]), | ||
| array_sum([1.1, 2.2]), | ||
| array_sum([1, -1, 0, 22]), | ||
| array_sum([1, -1, 0, null, 22]); |
There was a problem hiding this comment.
Suggested change
| array_sum([1, -1, 0, null, 22]); | |
| array_sum([1, -1, 0, null, 22]), | |
| array_sum([]), | |
| array_sum([null]); |
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
jayzhan211
force-pushed
the
array-sum
branch
from
236dd28
to
a4d6b22
Compare
|
I am trying to go through old PRs and make sure we don't lose any -- this one has not had much activity and has accumulated conflicts. Marking as draft so it isn't on the review queue. Please feel free to reopen / mark as ready for review if it is |
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Ref #7213
Ref #7214
Close #7242
Rationale for this change
Alternative approach to #7242
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
Additional Context
SELECT list_aggregate([2, 4, 8, 42], 'string_agg', '|'), so dont close Implementarray_aggregatefunction #7213 .