Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage for unbounded and bounded cases #8581

Merged
merged 10 commits into from
Dec 19, 2023
Merged

Increase test coverage for unbounded and bounded cases #8581

merged 10 commits into from
Dec 19, 2023

Conversation

mustafasrepo
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

In the PR we parametrize tests to increase test coverage. This PR extends this PR so that tests consider unbounded, and bounded sources when prefer_existing_sort flag is false and true.
All of the changes are in tests. This PR effectively increases test coverage.

What changes are included in this PR?

Are these changes tested?

Yes

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label Dec 19, 2023
Copy link
Contributor

@ozankabak ozankabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and it looks good to me. Hopefully these tests will help us avoid any regressions in both bounded and unbounded cases as we work on more sort-based optimizations

@ozankabak
Copy link
Contributor

ozankabak commented Dec 19, 2023

Since this doesn't change any code except tests I will go ahead and merge it to let code flow. In case of any future issues related to this PR, we will quickly address with follow-ons.

@ozankabak ozankabak merged commit 9bc61b3 into apache:main Dec 19, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants