Fix InListExpr to return the correct number of rows #8601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Dec 20, 2023
| let value = self.expr.evaluate(batch)?; | ||
| let r = match &self.static_filter { | ||
| Some(f) => f.contains(value.into_array(1)?.as_ref(), self.negated)?, | ||
| Some(f) => f.contains(value.into_array(num_rows)?.as_ref(), self.negated)?, |
There was a problem hiding this comment.
This is the actual fix -- the rest of the PR is test
alamb
force-pushed
the
alamb/fix_page_filter
branch
from
15881bc to
a77d6a2
Compare
viirya
approved these changes
Dec 20, 2023
Dandandan
reviewed
Dec 21, 2023
| let value = self.expr.evaluate(batch)?; | ||
| let r = match &self.static_filter { | ||
| Some(f) => f.contains(value.into_array(1)?.as_ref(), self.negated)?, | ||
| Some(f) => f.contains(value.into_array(num_rows)?.as_ref(), self.negated)?, | ||
| None => { | ||
| let value = value.into_array(batch.num_rows())?; |
There was a problem hiding this comment.
Maybe we can use the let value = value.into_array(batch.num_rows())?; for both arms here (before matching).
There was a problem hiding this comment.
Good idea -- done in 7cde104
|
Thanks @alamb ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8600
Rationale for this change
This was causing a panic for us when reading parquet files when pushing down filters . More details on #8600
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
Bug fix