Remove DescribeTableStmt in parser in favour of existing functionality from sqlparser-rs #8703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y from sqlparser-rs
Jefffrey
changed the title
Closed
|
Thank you for the research about |
9 tasks
roeap
pushed a commit
to delta-io/delta-rs
that referenced
this pull request
Jan 30, 2024
# Description This PR upgrades `delta-rs` to using DataFusion 35.0, which was recently released. In order to do this, I had to fix a few breaking changes, and also upgrade Arrow to 50 and `sqlparser` to 0.41. # Related Issue(s) N/A # Documentation See here for the list of PRs which required code change: - apache/datafusion#8703 - https://github.com/apache/arrow-datafusion/blob/ec6abece2dcfa68007b87c69eefa6b0d7333f628/dev/changelog/35.0.0.md?plain=1#L227 --------- Co-authored-by: Ming Ying <ming.ying.nyc@gmail.com>
rtyler
pushed a commit
to dispanser/delta-rs
that referenced
this pull request
Jan 31, 2024
# Description This PR upgrades `delta-rs` to using DataFusion 35.0, which was recently released. In order to do this, I had to fix a few breaking changes, and also upgrade Arrow to 50 and `sqlparser` to 0.41. # Related Issue(s) N/A # Documentation See here for the list of PRs which required code change: - apache/datafusion#8703 - https://github.com/apache/arrow-datafusion/blob/ec6abece2dcfa68007b87c69eefa6b0d7333f628/dev/changelog/35.0.0.md?plain=1#L227 --------- Co-authored-by: Ming Ying <ming.ying.nyc@gmail.com>
RobinLin666
pushed a commit
to RobinLin666/delta-rs
that referenced
this pull request
Feb 2, 2024
# Description This PR upgrades `delta-rs` to using DataFusion 35.0, which was recently released. In order to do this, I had to fix a few breaking changes, and also upgrade Arrow to 50 and `sqlparser` to 0.41. # Related Issue(s) N/A # Documentation See here for the list of PRs which required code change: - apache/datafusion#8703 - https://github.com/apache/arrow-datafusion/blob/ec6abece2dcfa68007b87c69eefa6b0d7333f628/dev/changelog/35.0.0.md?plain=1#L227 --------- Co-authored-by: Ming Ying <ming.ying.nyc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4808
Rationale for this change
Start incrementally removing Datafusion parser extensions in favour of migrating them to sqlparser-rs. In this case, sqlparser-rs already supports explain table behaviour:
https://github.com/sqlparser-rs/sqlparser-rs/blob/a75778c8c7ef48e0ceff96637146b57912d2e10b/src/ast/mod.rs#L2091-L2101
So just remove the custom Datafusion code here.
What changes are included in this PR?
Remove Datafusion parser extension code for
describe table_nameSQL statement as parsing of this is already supported by sqlparser-rsAre these changes tested?
Existing sqllogictest for describe ensures no breaking changes:
https://github.com/apache/arrow-datafusion/blob/bf3bd9259aa0e93ccc2c79a606207add30d004a4/datafusion/sqllogictest/test_files/describe.slt#L29-L34
Are there any user-facing changes?