Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support to_timestamp with optional chrono formats #8886

Merged
merged 19 commits into from
Jan 20, 2024
Merged

support to_timestamp with optional chrono formats #8886

merged 19 commits into from
Jan 20, 2024
+1,115 −179

Commits on Jan 16, 2024

  1. Support to_timestamp with chrono formatting apache#5398

    @Omega359
    Omega359 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    c5e230a View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into 5398-timestamp_with_f… 

    …ormats
    @Omega359
    Omega359 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    ef6723b View commit details
    Browse the repository at this point in the history

  3. Updated user guide's to_timestamp to include chrono formatting inform… 

    …ation apache#5398
    @Omega359
    Omega359 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    a48ab54 View commit details
    Browse the repository at this point in the history

  4. Minor comment update.

    @Omega359
    Omega359 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    3123539 View commit details
    Browse the repository at this point in the history

  5. Small documentation updates for to_timestamp functions.

    @Omega359
    Omega359 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    573456d View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/main' into 5398-timestamp_with… 

    …_formats
    @Omega359
    Omega359 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    66bf2e3 View commit details
    Browse the repository at this point in the history

  7. Cargo fmt and clippy improvements.

    @Omega359
    Omega359 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    a78a85a View commit details
    Browse the repository at this point in the history

  8. Switched to assert and unwrap_err based on feedback

    @Omega359
    Omega359 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    c06adcb View commit details
    Browse the repository at this point in the history

  9. Fixed assert, code compiles and runs as expected now.

    @Omega359
    Omega359 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    d14bb0b View commit details
    Browse the repository at this point in the history

  10. Fix fmt (again).

    @Omega359
    Omega359 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    a83b900 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Merge remote-tracking branch 'upstream/main' into 5398-timestamp_with… 

    …_formats
    @Omega359
    Omega359 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    0fb0dd2 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Add additional to_timestamp tests covering usage with tables with and… 

    … without valid formats.
    @Omega359
    Omega359 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    db071cc View commit details
    Browse the repository at this point in the history

  2. to_timestamp documentation fixes.

    @Omega359
    Omega359 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    40d932c View commit details
    Browse the repository at this point in the history

  3. - Changed internal_err! -> exec_err! for unsupported data type errors. 

    - Extracted out to_timestamp_impl method to reduce code duplication as per PR feedback.
- Extracted out validate_to_timestamp_data_types to reduce code duplication as per PR feedback.
- Added additional tests for argument validation and invalid arguments.
- Removed unnecessary shim function 'string_to_timestamp_nanos_with_format_shim'
    @Omega359
    Omega359 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    77f08ff View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Merge remote-tracking branch 'upstream/main' into 5398-timestamp_with… 

    …_formats

# Conflicts:
#	datafusion/proto/src/logical_plan/from_proto.rs
    @Omega359
    Omega359 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    1b637ae View commit details
    Browse the repository at this point in the history

  2. Resolved merge conflict, updated toStringXXX methods to reflect upstr… 

    …eam change
    @Omega359
    Omega359 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    951809a View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'apache/main' into 5398-timestamp_with_f… 

    …ormats
    @alamb
    alamb committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    4fcecb3 View commit details
    Browse the repository at this point in the history

  4. prettier

    @alamb
    alamb committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    406fd77 View commit details
    Browse the repository at this point in the history

  5. Fix clippy

    @alamb
    alamb committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    3c01f75 View commit details
    Browse the repository at this point in the history