chore(pruning): Support IS NOT NULL predicates in PruningPredicate
#9208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
alamb
changed the title
PruningPredicateIS NOT NULL predicates in PruningPredicate
alamb
reviewed
Feb 13, 2024
There was a problem hiding this comment.
Thank you @appletreeisyellow -- this looks great. The PR description is clear and the code is 👍
Can you please one more test of this logic integrated into the overall row group pruning logic (to make sure it works in the context of a predicate). I think you can follow the model of these tests for IS NULL:
cc @viirya who I think contributed the original IS NULL rewrite
viirya
reviewed
Feb 13, 2024
datafusion/core/src/datasource/physical_plan/parquet/row_groups.rs
Outdated
Show resolved
Hide resolved
chore: remove Debug derive
appletreeisyellow
force-pushed
the
chunchun/pruning-predicate-test-is-null
branch
from
60ea827 to
5040cf8
Compare
Comment on lines
-629
to
+636
| // int > 1 and IsNull(bool) => c1_max > 1 and bool_null_count > 0 | ||
| // c1 > 15 and IsNull(c2) => c1_max > 15 and c2_null_count > 0 |
There was a problem hiding this comment.
Update comment to reflect the examples given in the test
viirya
reviewed
Feb 13, 2024
Comment on lines
-629
to
+636
| // int > 1 and IsNull(bool) => c1_max > 1 and bool_null_count > 0 | ||
| // c1 > 15 and IsNull(c2) => c1_max > 15 and c2_null_count > 0 |
datafusion/core/src/datasource/physical_plan/parquet/row_groups.rs
Outdated
Show resolved
Hide resolved
viirya
reviewed
Feb 13, 2024
viirya
approved these changes
Feb 13, 2024
Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
alamb
approved these changes
Feb 13, 2024
appletreeisyellow
deleted the
chunchun/pruning-predicate-test-is-null
branch
|
I believe this PR has a logic bug that we did not catch in code review: #9230 |
appletreeisyellow
added a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Feb 14, 2024
…redicate` (apache#9208)" This reverts commit cc139c9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Help with #9171 and #7869
Rationale for this change
PruningPredicaterewrites the original predicate into an expression that references min/max/null_count values of each column in the original predicateCurrently,
IS NOT NULLis not supported, which means the rewritten predicate is ALWAYS TRUE, e.g.:x IS NOT NULLtrueSee the code below,
phys_expr::IsNotNullExpris not listed/supported:https://github.com/apache/arrow-datafusion/blob/292865e38cba1275a0f863230d816ee0e08c1318/datafusion/core/src/physical_optimizer/pruning.rs#L1139-L1140
What changes are included in this PR?
Support
IS NOT NULLpredicate rewrite, e.g.:x IS NOT NULLx_null_count = 0Are these changes tested?
Yes
Are there any user-facing changes?
No API change. User will experience performance improvements on queries that include
IS NOT NULLpredicates