Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: clarify performance in docs for ScalarUDF, ScalarUDAF and ScalarUDWF #9384

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Feb 28, 2024

Which issue does this PR close?

re #8578

Rationale for this change

@SteveLauC asked about why the "simple" APIs were less performant https://github.com/apache/arrow-datafusion/pull/8578/files#r1505483541

In researching the answer I concluded that they are not really less performant, and thus the documentation shouldn't imply they are.

What changes are included in this PR?

Update the docs to explain the difference better

Are these changes tested?

CI docs test

Are there any user-facing changes?

@alamb alamb added the documentation Improvements or additions to documentation label Feb 28, 2024
@alamb alamb marked this pull request as ready for review February 28, 2024 14:23
@github-actions github-actions bot added logical-expr Logical plan and expressions and removed documentation Improvements or additions to documentation labels Feb 28, 2024
@alamb alamb mentioned this pull request Feb 28, 2024
2 tasks
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb

Copy link
Contributor

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this:)

@alamb alamb merged commit a9e5247 into apache:main Feb 29, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logical-expr Logical plan and expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants