chore: simplify the return type of validate_data_types()
#9491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
|
FYI @Omega359 |
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Ref to #9077 (comment)
Rationale for this change
validate_data_types()has a logically unreachable typeColumnarValue. And this is sometimes misleading to the caller. Considering how it's implemented and would be used, I changed the return type toResult<()>to make it easier to invoke.This function is from #9388
What changes are included in this PR?
Change the return type of
validate_data_types()and corresponding callers.Are these changes tested?
N/A
Are there any user-facing changes?
No