Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port array_empty and array_length to datafusion-function-array crate #9510

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

Weijun-H
Copy link
Member

@Weijun-H Weijun-H commented Mar 9, 2024

Which issue does this PR close?

Relate #9285

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added logical-expr Logical plan and expressions physical-expr Physical Expressions labels Mar 9, 2024
@@ -588,6 +588,17 @@ async fn roundtrip_expr_api() -> Result<()> {
cardinality(array(vec![lit(1), lit(2), lit(3)])),
range(lit(1), lit(10), lit(2)),
gen_series(lit(1), lit(10), lit(2)),
array_has(array(vec![lit(1), lit(2), lit(3)]), lit(1)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@jayzhan211 jayzhan211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jayzhan211 jayzhan211 merged commit b1d8082 into apache:main Mar 9, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logical-expr Logical plan and expressions physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants