move array_replace family functions to datafusion-function-array crate #9651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
Weijun-H
force-pushed
the
move-array-replace-family
branch
2 times, most recently
from
a6c47ec to
ba2a344
Compare
43 tasks
Weijun-H
force-pushed
the
move-array-replace-family
branch
from
4ff9ba0 to
c199e4c
Compare
comphead
approved these changes
Mar 17, 2024
Weijun-H
force-pushed
the
move-array-replace-family
branch
from
f8ec815 to
b0324cd
Compare
jayzhan211
reviewed
Mar 18, 2024
| /// [[1, 2, 3], [2, 3, 4], [2, 3, 4]], [[1, 2, 3], [2, 3, 4], [3, 4, 5]], 1, false => [true, false, false] | ||
| /// ) | ||
| /// ``` | ||
| pub(crate) fn compare_element_to_list( |
There was a problem hiding this comment.
We can move it to utils, not only replace functions rely on it.
jayzhan211
reviewed
Mar 18, 2024
| @@ -115,6 +119,9 @@ pub fn register_all(registry: &mut dyn FunctionRegistry) -> Result<()> { | |||
| set_ops::array_union_udf(), | |||
| position::array_position_udf(), | |||
| position::array_positions_udf(), | |||
| array_replace::array_replace_n_udf(), | |||
There was a problem hiding this comment.
nit: I think we can name it replace
jayzhan211
reviewed
Mar 18, 2024
| from_array.clone(), | ||
| to_array.clone() | ||
| ), | ||
| criterion::black_box(&expected_array).clone() |
There was a problem hiding this comment.
is it possible to avoid the clone here? it is already cloned in L38
Weijun-H
force-pushed
the
move-array-replace-family
branch
from
c771529 to
69a286a
Compare
|
Thanks @Weijun-H ! I pushed a commit to this branch to resolve the CI failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Relate #9285
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?