[MINOR]: Remove some .unwraps from nth_value.rs file
#9674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@huaxingao If you have time, I would appreciate your review to make sure this refactor preserves original behaviour |
huaxingao
approved these changes
Mar 18, 2024
alamb
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Looks good to me too -- thank you @mustafasrepo and @huaxingao
comphead
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
While reviewing PR9625. I recognized that we can remove some
.unwraps from the file by changing the implementation (Please note that, as far as I can tell, thoseunwraps are safe though).What changes are included in this PR?
This Pr, removes
.unwraps in thenth_value.rsfile.Are these changes tested?
Existing tests.
Are there any user-facing changes?