Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Run ScalarValue size test on aarch again #9728

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Minor: Run ScalarValue size test on aarch again #9728

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8708b7b
Minor: Run ScalarValue size test on aarch again
alamb Mar 21, 2024
af684c9
add comments
alamb Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions datafusion/common/src/scalar/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4528,18 +4528,18 @@ mod tests {
assert_eq!(expected, data_type.try_into().unwrap())
}

// this test fails on aarch, so don't run it there
#[cfg(not(target_arch = "aarch64"))]
#[test]
fn size_of_scalar() {
// Since ScalarValues are used in a non trivial number of places,
// making it larger means significant more memory consumption
// per distinct value.
//
// Thus this test ensures that no code change makes ScalarValue larger
//
// The alignment requirements differ across architectures and
// thus the size of the enum appears to as well

// The value can be changed depending on rust version
// The value may also change depending on rust version
assert_eq!(std::mem::size_of::<ScalarValue>(), 64);
}

Expand Down
Loading